#2782

Code comments can smell pt II

So I sent my code comments post to the developers in the VSTO PU… for their entertainment and edification.

This got several people, including Eric onto other obvious code smells including; multiple if… else, switches and methods that take booleans. All of which boil down to methods that do more than one thing. So if a method comment says “does X or Y when …” this is comment smell – your method is a candidate for refactoring.

Which all leads to Brian’s Extreme Refactoring. No privates, one line methods, and no duplication.

Two posts in one day?! Apologies, I’ll try not to let it happen again.